Fix parametrization reload #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arametric testcases are captured.
kn-ms
reviewed
Aug 14, 2023
| .entries[new_case_index] | ||
| .uid | ||
| ] | ||
| tc = new_report[mt.uid][st.uid].entries[new_case_index] |
There was a problem hiding this comment.
consider to introduce temporary variables instead of those long indexing chains. Speaking names could make this more(euphemism) readable.
There was a problem hiding this comment.
Moved most of it to enumerate.
kn-ms
previously approved these changes
Aug 14, 2023
Pyifan
requested changes
Aug 15, 2023
| except KeyError: # new testcase | ||
| pass | ||
| mt.entries[st_index] = new_st | ||
| if isinstance(case, TestGroupReport): |
There was a problem hiding this comment.
Can we add some test coverage for this change? To prevent future regression. Otherwise this looks great!
M6AI
force-pushed
the
bugfix/parametrization_reload
branch
from
1b3e577 to
42d0026
Compare
M6AI
commented
Aug 15, 2023
| # We reload and assert | ||
| irunner.reload_report() | ||
|
|
||
| for test in irunner.report: |
There was a problem hiding this comment.
@Pyifan In a nutshell, this test does the following:
- ensures that runtime status actually moves to ready upon change (this is functionally irrelevant tho)
- checks whether the original report state got restored (after alterations with new cases and parametrizations or removals of either) and whether everything at testcase level that was run and kept have been preserved under the reload
Seems smoother with public setters than mocking some behavior using proper mocks.
Pyifan
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
Currently, the reload feature of the interactive UI does not capture changes to parametric testcases at parametrization level. In fact, changing any of the parameters will result in the old parameters possibly pointing to non-existent cases and the UI becomes hanging.
Solution description
Added parametrization level to the report reload so that changes to parametric testcases are captured.
Checklist: